Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ada to 2.8.0 #53254

Merged
merged 1 commit into from
Jun 4, 2024
Merged

deps: update ada to 2.8.0 #53254

merged 1 commit into from
Jun 4, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jun 2, 2024

This is an automated update of ada to 2.8.0.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1567/

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jun 2, 2024
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jun 2, 2024

Review requested:

  • @nodejs/security-wg
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 2, 2024
@anonrig
Copy link
Member

anonrig commented Jun 2, 2024

nit: we have done some performance improvements on Ada. @nodejs/performance can anybody run the benchmark ci on URL?

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2024
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0986817 into main Jun 4, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 0986817

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch June 4, 2024 00:33
RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
PR-URL: #53254
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53254
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#53254
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53254
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53254
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants