Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: throw on invalid encoding in Buffer.from #54586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 27, 2024

Refs: #54533

@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 27, 2024
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Aug 27, 2024
ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024
@ronag ronag requested a review from mcollina August 27, 2024 05:36
@ronag
Copy link
Member Author

ronag commented Aug 27, 2024

@nodejs/buffer

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (c00ea01) to head (9d335ca).
Report is 141 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54586      +/-   ##
==========================================
- Coverage   87.33%   87.32%   -0.01%     
==========================================
  Files         649      649              
  Lines      182620   182632      +12     
  Branches    35044    35033      -11     
==========================================
- Hits       159484   159481       -3     
- Misses      16397    16419      +22     
+ Partials     6739     6732       -7     
Files with missing lines Coverage Δ
lib/buffer.js 96.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Aug 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot
Copy link
Collaborator

lib/buffer.js Outdated Show resolved Hide resolved
ronag added a commit to nxtedition/node that referenced this pull request Aug 27, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

We should likely fix throughv test. I'll get to it when I can.

jasnell
jasnell previously approved these changes Aug 31, 2024
@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

PR is currently blocked from landing due to unreliable CI. Likely needs a rebase

@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell dismissed their stale review September 8, 2024 17:24

There are relevant non-flaky CI failures that need to be addressed with this PR

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants