zlib: add typings for better dx #54699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
LiviaMedeiros
approved these changes
Sep 1, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Sep 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
force-pushed
the
yagiz/zlib-add-typings
branch
from
e70548b
to
36c76be
Compare
anonrig
force-pushed
the
yagiz/zlib-add-typings
branch
from
36c76be
to
bda112f
Compare
anonrig
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54699 ✔ Done loading data for nodejs/node/pull/54699 ----------------------------------- PR info ------------------------------------ Title zlib: add typings for better dx (#54699) Author Yagiz Nizipli <[email protected]> (@anonrig) Branch anonrig:yagiz/zlib-add-typings -> nodejs:main Labels zlib, author ready, needs-ci, typings Commits 1 - zlib: add typings for better dx Committers 1 - Yagiz Nizipli <[email protected]> PR-URL: https:/nodejs/node/pull/54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https:/nodejs/node/pull/54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - zlib: add typings for better dx ℹ This PR was created on Sun, 01 Sep 2024 17:15:33 GMT ✔ Approvals: 2 ✔ - LiviaMedeiros (@LiviaMedeiros): https:/nodejs/node/pull/54699#pullrequestreview-2274466297 ✔ - James M Snell (@jasnell) (TSC): https:/nodejs/node/pull/54699#pullrequestreview-2281130479 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-11T03:03:50Z: https://ci.nodejs.org/job/node-test-pull-request/62301/ - Querying data for job/node-test-pull-request/62301/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps:/nodejs/node/actions/runs/10863187549 |
LiviaMedeiros
approved these changes
Sep 14, 2024
LiviaMedeiros
pushed a commit
that referenced
this pull request
Sep 14, 2024
PR-URL: #54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in f468509 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54699 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typescript types for better development experience, and made some small refactorings along the way.