Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove dead code in test-http2-misbehaving-multiplex #54860

Merged
merged 2 commits into from
Sep 12, 2024
+7 −24
Merged

test: remove dead code in test-http2-misbehaving-multiplex #54860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cad17b
test: remove dead code in test-http2-misbehaving-multiplex
lpinca Sep 9, 2024
b7ef4a2
fixup! test: remove dead code in test-http2-misbehaving-multiplex
lpinca Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions test/parallel/test-http2-misbehaving-multiplex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,35 +11,18 @@
const net = require('net');
const { NghttpError } = require('internal/http2/util');
const h2test = require('../common/http2');
let client;

const server = h2.createServer();
let gotFirstStreamId1;
server.on('stream', common.mustCall((stream) => {
stream.respond();
stream.end('ok');

// Http2Server should be fast enough to respond to and close
// the first streams with ID 1 and ID 3 without errors.

// Test for errors in 'close' event to ensure no errors on some streams.
stream.on('error', () => {});
stream.on('close', (err) => {
if (stream.id === 1) {
if (gotFirstStreamId1) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this branch was taken, the test would fail because there is nothing that calls the function returned by common.expectsError() below.

// We expect our outgoing frames to fail on Stream ID 1 the second time
// because a stream with ID 1 was already closed before.
common.expectsError({
constructor: NghttpError,
code: 'ERR_HTTP2_ERROR',
message: 'Stream was already closed or invalid'
});
return;
}
gotFirstStreamId1 = true;
}
assert.strictEqual(err, undefined);
});
stream.on('error', common.expectsError({
code: 'ERR_HTTP2_ERROR',
constructor: NghttpError,
message: 'Stream was already closed or invalid'
}));
stream.on('close', common.mustCall());

// Stream ID 5 should never reach the server
assert.notStrictEqual(stream.id, 5);
Expand All @@ -62,7 +45,7 @@
const id5 = new h2test.HeadersFrame(5, h2test.kFakeRequestHeaders, 0, true);

server.listen(0, () => {
client = net.connect(server.address().port, () => {
let client = net.connect(server.address().port, () => {

Check failure on line 48 in test/parallel/test-http2-misbehaving-multiplex.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'client' is never reassigned. Use 'const' instead
client.write(h2test.kClientMagic, () => {
client.write(settings.data, () => {
client.write(settingsAck.data);
Expand Down
Loading