-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: optimize EventTarget.addEventListener #55312
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
4a4c150
to
6f397eb
Compare
@benjamingr could we use a |
6f397eb
to
26c85fa
Compare
Is there a reason we can't skip using addEventListener altogether and directly append the listener to the signal's abort algorithms? |
7beec6a
to
4ef0c0b
Compare
26c85fa
to
9570840
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55312 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 652
Lines 186594 186788 +194
Branches 36054 36037 -17
==========================================
+ Hits 164980 165126 +146
- Misses 14883 14925 +42
- Partials 6731 6737 +6
|
9570840
to
611bc6c
Compare
611bc6c
to
c934127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ronag linting is failing |
Fixes: #55311