Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Fix readableState.awaitDrain mechanism #6023

Closed

Commits on Apr 3, 2016

  1. stream: Fix readableState.awaitDrain mechanism

    In 6899094 (nodejs#2325),
    the conditions for increasing `readableState.awaitDrain` when
    writing to a piping destination returns false were changed so
    that they could not actually be met, effectively leaving
    `readableState.awaitDrain` with a constant value of 0.
    
    This patch changes the conditions to testing whether the
    stream for which `.write()` returned false is still a piping
    destination, which was likely the intention of the original
    patch.
    
    Fixes: nodejs#5820
    addaleax committed Apr 3, 2016
    Configuration menu
    Copy the full SHA
    21f7246 View commit details
    Browse the repository at this point in the history