V5.11.0 proposal

.eslintignore

@@ -1,5 +1,4 @@
 lib/internal/v8_prof_polyfill.js
-lib/internal/v8_prof_processor.js
 lib/punycode.js
 test/addons/??_*/
 test/fixtures

.eslintrc

@@ -13,7 +13,7 @@ rules:
  no-duplicate-case: 2
  no-empty-character-class: 2
  no-ex-assign: 2
- no-extra-boolean-cast : 2
+ no-extra-boolean-cast: 2
  no-extra-parens: [2, "functions"]
  no-extra-semi: 2
  no-func-assign: 2
@@ -85,8 +85,9 @@ rules:
  prefer-const: 2
 
  # Custom rules in tools/eslint-rules
+ assert-fail-single-argument: 2
  new-with-error: [2, "Error", "RangeError", "TypeError", "SyntaxError", "ReferenceError"]
-
+ align-multiline-assignment: 2
 
 # Global scoped method and vars
 globals:

.gitignore

@@ -41,6 +41,8 @@ _UpgradeReport_Files/
 ipch/
 *.sdf
 *.opensdf
+*.VC.opendb
+.vs/
 
 /config.mk
 /config.gypi

BUILDING.md

@@ -87,7 +87,14 @@ To test if Node.js was built correctly:
 $ node -e "console.log('Hello from Node.js ' + process.version)"
 ```
 
-### Android / Android based devices, aka. Firefox OS
+### Android / Android-based devices (e.g., Firefox OS)
+
+Although these instructions for building on Android are provided, please note
+that Android is not an officially supported platform at this time. Patches to
+improve the Android build are accepted. However, there is no testing on Android
+in the current continuous integration environment. The participation of people
+dedicated and determined to improve Android building, testing, and support is
+encouraged.
 
 Be sure you have downloaded and extracted [Android NDK]
 (https://developer.android.com/tools/sdk/ndk/index.html)

CONTRIBUTING.md

@@ -49,7 +49,7 @@ and built upon.
 #### Respect the stability index
 
 The rules for the master branch are less strict; consult the
-[stability index](./doc/api/documentation.markdown#stability-index) for details.
+[stability index](./doc/api/documentation..md#stability-index) for details.
 
 In a nutshell, modules are at varying levels of API stability. Bug fixes are
 always welcome but API or behavioral changes to modules at stability level 3
@@ -173,6 +173,7 @@ to address, apply your changes in a separate commit and push that to your
 feature branch. Post a comment in the pull request afterwards; GitHub does
 not send out notifications when you add commits.
 
+<a id="developers-certificate-of-origin"></a>
 ## Developer's Certificate of Origin 1.1
 
 By making a contribution to this project, I certify that:

Makefile

@@ -8,9 +8,12 @@ PREFIX ?= /usr/local
 FLAKY_TESTS ?= run
 TEST_CI_ARGS ?=
 STAGINGSERVER ?= node-www
-
 OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
 
+ifdef JOBS
+ PARALLEL_ARGS = -j $(JOBS)
+endif
+
 ifdef QUICKCHECK
  QUICKCHECK_ARG := --quickcheck
 endif
@@ -128,7 +131,7 @@ test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
  --nodedir="$(shell pwd)"
 
 # Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
-test/addons/.docbuildstamp: doc/api/addons.markdown
+test/addons/.docbuildstamp: doc/api/addons.md
  $(RM) -r test/addons/??_*/
  $(NODE) tools/doc/addon-verify.js
  touch $@
@@ -168,7 +171,8 @@ test-all-valgrind: test-build
  $(PYTHON) tools/test.py --mode=debug,release --valgrind
 
 test-ci: | build-addons
- $(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=$(FLAKY_TESTS) \
+ $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
+ --mode=release --flaky-tests=$(FLAKY_TESTS) \
  $(TEST_CI_ARGS) addons message parallel sequential
 
 test-release: test-build
@@ -235,9 +239,9 @@ test-v8-benchmarks:
 test-v8-all: test-v8 test-v8-intl test-v8-benchmarks
  # runs all v8 tests
 
-apidoc_sources = $(wildcard doc/api/*.markdown)
-apidocs = $(addprefix out/,$(apidoc_sources:.markdown=.html)) \
- $(addprefix out/,$(apidoc_sources:.markdown=.json))
+apidoc_sources = $(wildcard doc/api/*.md)
+apidocs = $(addprefix out/,$(apidoc_sources:.md=.html)) \
+ $(addprefix out/,$(apidoc_sources:.md=.json))
 
 apidoc_dirs = out/doc out/doc/api/ out/doc/api/assets
 
@@ -254,10 +258,10 @@ out/doc/api/assets/%: doc/api_assets/% out/doc/api/assets/
 out/doc/%: doc/%
  cp -r $< $@
 
-out/doc/api/%.json: doc/api/%.markdown $(NODE_EXE)
+out/doc/api/%.json: doc/api/%.md $(NODE_EXE)
  $(NODE) tools/doc/generate.js --format=json $< > $@
 
-out/doc/api/%.html: doc/api/%.markdown $(NODE_EXE)
+out/doc/api/%.html: doc/api/%.md $(NODE_EXE)
  $(NODE) tools/doc/generate.js --format=html --template=doc/template.html $< > $@
 
 docopen: out/doc/api/all.html
@@ -469,15 +473,15 @@ doc-upload: tar
  scp -pr out/doc/ $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs/
  ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs.done"
 
-$(TARBALL)-headers: config.gypi release-only
+$(TARBALL)-headers: release-only
  $(PYTHON) ./configure \
  --prefix=/ \
  --dest-cpu=$(DESTCPU) \
  --tag=$(TAG) \
  --release-urlbase=$(RELEASE_URLBASE) \
  $(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
  HEADERS_ONLY=1 $(PYTHON) tools/install.py install '$(TARNAME)' '/'
- find $(TARNAME)/ -type l | xargs rm # annoying on windows
+ find $(TARNAME)/ -type l | xargs rm -f
  tar -cf $(TARNAME)-headers.tar $(TARNAME)
  rm -rf $(TARNAME)
  gzip -c -f -9 $(TARNAME)-headers.tar > $(TARNAME)-headers.tar.gz
@@ -592,8 +596,13 @@ bench-idle:
  $(NODE) benchmark/idle_clients.js &
 
 jslint:
- $(NODE) tools/eslint/bin/eslint.js benchmark lib src test tools/doc \
- tools/eslint-rules --rulesdir tools/eslint-rules
+ $(NODE) tools/jslint.js -J benchmark lib src test tools/doc \
+ tools/eslint-rules tools/jslint.js
+
+jslint-ci:
+ $(NODE) tools/jslint.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
+ benchmark lib src test tools/doc \
+ tools/eslint-rules tools/jslint.js
 
 CPPLINT_EXCLUDE ?=
 CPPLINT_EXCLUDE += src/node_lttng.cc
@@ -621,13 +630,13 @@ cpplint:
  @$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
 
 lint: jslint cpplint
-
-lint-ci: lint
+lint-ci: jslint-ci cpplint
 
 .PHONY: lint cpplint jslint bench clean docopen docclean doc dist distclean \
  check uninstall install install-includes install-bin all staticlib \
  dynamiclib test test-all test-addons build-addons website-upload pkg \
  blog blogclean tar binary release-only bench-http-simple bench-idle \
  bench-all bench bench-misc bench-array bench-buffer bench-net \
  bench-http bench-fs bench-tls cctest run-ci test-v8 test-v8-intl \
- test-v8-benchmarks test-v8-all v8 lint-ci bench-ci
+ test-v8-benchmarks test-v8-all v8 lint-ci bench-ci jslint-ci \
+ $(TARBALL)-headers

README.md

@@ -70,7 +70,15 @@ documentation of the latest stable version.
 
 Stable, LTS and Nightly download directories all contain a *SHASUM256.txt*
 file that lists the SHA checksums for each file available for
-download. To check that a downloaded file matches the checksum, run
+download.
+
+The *SHASUM256.txt* can be downloaded using curl.
+
+```
+$ curl -O https://nodejs.org/dist/vx.y.z/SHASUMS256.txt
+```
+
+To check that a downloaded file matches the checksum, run
 it through `sha256sum` with a command such as:
 
 ```
@@ -159,6 +167,7 @@ information about the governance of the Node.js project, see
 
 ### Collaborators
 
+* [addaleax](https:/addaleax) - **Anna Henningsen** <[email protected]>
 * [AndreasMadsen](https:/AndreasMadsen) - **Andreas Madsen** <[email protected]>
 * [benjamingr](https:/benjamingr) - **Benjamin Gruenbaum** <[email protected]>
 * [brendanashworth](https:/brendanashworth) - **Brendan Ashworth** <[email protected]>
@@ -168,6 +177,7 @@ information about the governance of the Node.js project, see
 * [geek](https:/geek) - **Wyatt Preul** <[email protected]>
 * [iarna](https:/iarna) - **Rebecca Turner** <[email protected]>
 * [isaacs](https:/isaacs) - **Isaac Z. Schlueter** <[email protected]>
+* [iWuzHere](https:/iWuzHere) - **Imran Iqbal** <[email protected]>
 * [jbergstroem](https:/jbergstroem) - **Johan Bergström** <[email protected]>
 * [joaocgreis](https:/joaocgreis) - **João Reis** <[email protected]>
 * [julianduque](https:/julianduque) - **Julian Duque** <[email protected]>
@@ -188,9 +198,11 @@ information about the governance of the Node.js project, see
 * [romankl](https:/romankl) - **Roman Klauke** <[email protected]>
 * [saghul](https:/saghul) - **Saúl Ibarra Corretgé** <[email protected]>
 * [sam-github](https:/sam-github) - **Sam Roberts** <[email protected]>
+* [santigimeno](https:/santigimeno) - **Santiago Gimeno** <[email protected]>
 * [seishun](https:/seishun) - **Nikolai Vavilov** <[email protected]>
 * [silverwind](https:/silverwind) - **Roman Reiss** <[email protected]>
 * [srl295](https:/srl295) - **Steven R Loomis** <[email protected]>
+* [stefanmb](https:/stefanmb) - **Stefan Budeanu** <[email protected]>
 * [targos](https:/targos) - **Michaël Zasso** <[email protected]>
 * [tellnes](https:/tellnes) - **Christian Tellnes** <[email protected]>
 * [thealphanerd](https:/thealphanerd) - **Myles Borins** <[email protected]>

benchmark/buffers/buffer-compare-offset.js

@@ -0,0 +1,58 @@
+'use strict';
+const common = require('../common.js');
+const v8 = require('v8');
+
+const bench = common.createBenchmark(main, {
+ method: ['offset', 'slice'],
+ size: [16, 512, 1024, 4096, 16386],
+ millions: [1]
+});
+
+function compareUsingSlice(b0, b1, len, iter) {
+
+ // Force optimization before starting the benchmark
+ Buffer.compare(b0.slice(1, len), b1.slice(1, len));
+ v8.setFlagsFromString('--allow_natives_syntax');
+ eval('%OptimizeFunctionOnNextCall(Buffer.compare)');
+ eval('%OptimizeFunctionOnNextCall(b0.slice)');
+ eval('%OptimizeFunctionOnNextCall(b1.slice)');
+ Buffer.compare(b0.slice(1, len), b1.slice(1, len));
+ doCompareUsingSlice(b0, b1, len, iter);
+}
+
+function doCompareUsingSlice(b0, b1, len, iter) {
+ var i;
+ bench.start();
+ for (i = 0; i < iter; i++)
+ Buffer.compare(b0.slice(1, len), b1.slice(1, len));
+ bench.end(iter / 1e6);
+}
+
+function compareUsingOffset(b0, b1, len, iter) {
+ len = len + 1;
+ // Force optimization before starting the benchmark
+ b0.compare(b1, 1, len, 1, len);
+ v8.setFlagsFromString('--allow_natives_syntax');
+ eval('%OptimizeFunctionOnNextCall(b0.compare)');
+ b0.compare(b1, 1, len, 1, len);
+ doCompareUsingOffset(b0, b1, len, iter);
+}
+
+function doCompareUsingOffset(b0, b1, len, iter) {
+ var i;
+ bench.start();
+ for (i = 0; i < iter; i++)
+ b0.compare(b1, 1, len, 1, len);
+ bench.end(iter / 1e6);
+}
+
+function main(conf) {
+ const iter = (conf.millions >>> 0) * 1e6;
+ const size = (conf.size >>> 0);
+ const method = conf.method === 'slice' ?
+ compareUsingSlice : compareUsingOffset;
+ method(Buffer.alloc(size, 'a'),
+ Buffer.alloc(size, 'b'),
+ size >> 1,
+ iter);
+}

benchmark/module/module-loader.js

@@ -7,15 +7,17 @@ var tmpDirectory = path.join(__dirname, '..', 'tmp');
 var benchmarkDirectory = path.join(tmpDirectory, 'nodejs-benchmark-module');
 
 var bench = common.createBenchmark(main, {
- thousands: [50]
+ thousands: [50],
+ fullPath: ['true', 'false']
 });
 
 function main(conf) {
+ var n = +conf.thousands * 1e3;
+
  rmrf(tmpDirectory);
  try { fs.mkdirSync(tmpDirectory); } catch (e) {}
  try { fs.mkdirSync(benchmarkDirectory); } catch (e) {}
 
- var n = +conf.thousands * 1e3;
  for (var i = 0; i <= n; i++) {
  fs.mkdirSync(benchmarkDirectory + i);
  fs.writeFileSync(
@@ -28,10 +30,21 @@ function main(conf) {
  );
  }
 
- measure(n);
+ if (conf.fullPath === 'true')
+ measureFull(n);
+ else
+ measureDir(n);
+}
+
+function measureFull(n) {
+ bench.start();
+ for (var i = 0; i <= n; i++) {
+ require(benchmarkDirectory + i + '/index.js');
+ }
+ bench.end(n / 1e3);
 }
 
-function measure(n) {
+function measureDir(n) {
  bench.start();
  for (var i = 0; i <= n; i++) {
  require(benchmarkDirectory + i);

common.gypi

@@ -95,7 +95,7 @@
  'variables': {
  'v8_enable_handle_zapping': 0,
  },
- 'cflags': [ '-O3', '-ffunction-sections', '-fdata-sections' ],
+ 'cflags': [ '-O3' ],
  'conditions': [
  ['target_arch=="x64"', {
  'msvs_configuration_platform': 'x64',

deps/http_parser/Makefile

@@ -22,14 +22,14 @@ PLATFORM ?= $(shell sh -c 'uname -s | tr "[A-Z]" "[a-z]"')
 HELPER ?=
 BINEXT ?=
 ifeq (darwin,$(PLATFORM))
-SONAME ?= libhttp_parser.2.6.2.dylib
+SONAME ?= libhttp_parser.2.7.0.dylib
 SOEXT ?= dylib
 else ifeq (wine,$(PLATFORM))
 CC = winegcc
 BINEXT = .exe.so
 HELPER = wine
 else
-SONAME ?= libhttp_parser.so.2.6.2
+SONAME ?= libhttp_parser.so.2.7.0
 SOEXT ?= so
 endif
 

deps/http_parser/http_parser.c

@@ -1812,6 +1812,9 @@ size_t http_parser_execute (http_parser *parser,
  case 0:
  break;
 
+ case 2:
+ parser->upgrade = 1;
+
  case 1:
  parser->flags |= F_SKIPBODY;
  break;

deps/http_parser/http_parser.h

@@ -26,8 +26,8 @@ extern "C" {
 
 /* Also update SONAME in the Makefile whenever you change these. */
 #define HTTP_PARSER_VERSION_MAJOR 2
-#define HTTP_PARSER_VERSION_MINOR 6
-#define HTTP_PARSER_VERSION_PATCH 2
+#define HTTP_PARSER_VERSION_MINOR 7
+#define HTTP_PARSER_VERSION_PATCH 0
 
 #include <sys/types.h>
 #if defined(_WIN32) && !defined(__MINGW32__) && \
@@ -77,6 +77,11 @@ typedef struct http_parser_settings http_parser_settings;
  * HEAD request which may contain 'Content-Length' or 'Transfer-Encoding:
  * chunked' headers that indicate the presence of a body.
  *
+ * Returning `2` from on_headers_complete will tell parser that it should not
+ * expect neither a body nor any futher responses on this connection. This is
+ * useful for handling responses to a CONNECT request which may not contain
+ * `Upgrade` or `Connection: upgrade` headers.
+ *
  * http_data_cb does not return data chunks. It will be called arbitrarily
  * many times for each string. E.G. you might get 10 callbacks for "on_url"
  * each providing just a few characters more data.