Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve error message in test-tick-processor #7693

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 12, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Provide additional information about values that indicate test failed.

Provide additional information about values that indicate test failed.
@Trott Trott added the test Issues and PRs related to the tests. label Jul 12, 2016
}
var log = matches[0];
var out = cp.execSync(process.execPath +
' --prof-process --call-graph-size=10 ' + log,
{encoding: 'utf8'});
assert(pattern.test(out));
assert(pattern.test(out), `${pattern} not matchint ${out}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching?

Whoops, yes, fixed.

@cjihrig
Copy link
Contributor

cjihrig commented Jul 12, 2016

LGTM with a question.

@mscdex
Copy link
Contributor

mscdex commented Jul 13, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jul 13, 2016

@Trott
Copy link
Member Author

Trott commented Jul 15, 2016

Landed in d11f475 9dc0651

@Trott Trott closed this Jul 15, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jul 15, 2016

The commit appears to be missing metadata.

@Trott
Copy link
Member Author

Trott commented Jul 15, 2016

Unfortunately, yes. Hopping on IRC to figure best thing to do about it, if anything...

Trott added a commit to Trott/io.js that referenced this pull request Jul 15, 2016
Provide additional information about values that indicate test failed.

PR-URL: nodejs#7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 15, 2016

Re-landed in 9dc0651 and force pushed. :-|

evanlucas pushed a commit that referenced this pull request Jul 18, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Provide additional information about values that indicate test failed.

PR-URL: #7693
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@Trott Trott deleted the tick-tock branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants