test: fix flaky test-http-server-consumed-timeout #7717
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test http
Description of change
Using identical timeout values appears to have eliminated the flakiness in the test.
Fixes: #7643
With this change to the test and removing the fix in #6286, everything fails (as it should): https://ci.nodejs.org/job/node-stress-single-test/804/ (Test run just once on each platform)
With this change to the test only, everything passes (as it should): https://ci.nodejs.org/job/node-stress-single-test/805/ (Test run 100 times on each platform)
And with this change, the test is not flaky on FreeBSD:
https://ci.nodejs.org/job/node-stress-single-test/806/nodes=freebsd10-64/console (9999 runs, 0 failures)
For comparison, the test is flaky on current master on FreeBSD:
https://ci.nodejs.org/job/node-stress-single-test/807/nodes=freebsd10-64/console
(also 9999 runs, 1 failure, so not the overwhelming results I was hoping for, but at least it wasn't 0 failures...)
/cc @indutny
The flakiness is not terribly reproducible in the stress tests, but if it stands to reason that this reduces any race condition window, then it's probably worth doing.