Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,msi: fix inclusion of translations #7798

Closed

Conversation

joaocgreis
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Build, MSI.

Description of change

This PR fixes two issues with the MSI:

cc @nodejs/build @nodejs/platform-windows @pmq20 @mcollina

@joaocgreis joaocgreis added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. build Issues and PRs related to build files or the CI. labels Jul 19, 2016
@mscdex mscdex changed the title win,,msi: fix inclusion of translations win,msi: fix inclusion of translations Jul 19, 2016
@@ -54,9 +54,12 @@
</WixExtension>
</ItemGroup>
<ItemGroup>
<!-- <EmbeddedResource Include="i18n\de-de.wxl" /> -->
<EmbeddedResource Include="i18n\en-us.wxl" />
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this not comment out all but english?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the plan on releasing with the translations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanlucas yes, this is supposed to be commented for now. The translations are not yet active, the installer only has english.

@fhemberger is there a plan to release with translations? Are we just waiting for more translations to arrive? On the build side, we use the stable release of WiX, so english and german are the only languages supported. The WiX website recommends not to use the weekly versions in production, but we could perhaps add just the translation files to the release version, if it works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaocgreis the issue there is that WiX guys are going to make a new release only for the next Visual Studio release so it could take time

wixtoolset/wix3#366 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaocgreis @fhemberger is using weekly build of WiX a viable option for building node installer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piccoloaiutante I'm a little hesitant to use a weekly build because the WiX website says not to, and breaking the MSI is something that would cause major pain for users. But I'd be willing to give it a try, provided that we build release candidates for a few versions and get them well tested. Using the translations with the release version still sounds better.

Do we have a plan for when to start shipping with this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaocgreis i don't have any visibility on when shipping localized installer

@mcollina
Copy link
Member

I have a very little experience in all of this.. cc @piccoloaiutante might help.

@evanlucas
Copy link
Contributor

If those translations are not even supported, I think I would prefer to back them out of the 6.3.1 proposal, at least until we figure this out. Thanks!

@joaocgreis
Copy link
Member Author

@evanlucas sounds good, for end users it's the same as it is now.

@joaocgreis
Copy link
Member Author

@nodejs/platform-windows can you please review? This will fix the nightlies.

@joaocgreis
Copy link
Member Author

@pmq20 @dead-horse @yorkie @fhemberger @XadillaX @mcollina @rvagg you submitted and reviewed the original PRs, this should be an easy review for you. Can you please take a look to get the releases unbroken and the nightlies flowing again?

@bzoz
Copy link
Contributor

bzoz commented Aug 1, 2016

LGTM

joaocgreis added a commit that referenced this pull request Aug 3, 2016
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #7798
@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3478/ (freebsd failure unrelated)

Landed in c9e670e

@joaocgreis joaocgreis closed this Aug 3, 2016
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #7798
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #7798
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #7798
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Reviewed-By: Bartosz Sosnowski <[email protected]>
PR-URL: #7798
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@bnoordhuis bnoordhuis mentioned this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants