Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MD012/no-multiple-blanks #2487

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 3, 2019

Remove multiple consecutive blanks.
Find:\n\n\n
Replace:\n\n
Filter:.md

Remove multiple consecutive blanks.
Find:\n\n\n
Replace:\n\n
Filter:.md
@nschonni nschonni force-pushed the fix--MD012/no-multiple-blanks branch from ac1757e to 567b202 Compare September 4, 2019 06:15
@@ -96,14 +96,12 @@ Requests per second: 3317.24 [#/sec] (mean)
# 0.8.0
Requests per second: 3795.34 [#/sec] (mean) +14.41%


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes line in pres too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Looking at the other blocks in this file, the double line in the other calls isn't consistent, so i don't think it matters in this case

Copy link
Contributor

@SEWeiTung SEWeiTung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a confirm:locale/en/blog/announcements/interactive-2016-ams.md, it seems that we should keep the last line as a newline (L84), but this change will remove it? If we don't have such problems, this LGTM for me.

@nschonni
Copy link
Member Author

nschonni commented Sep 5, 2019

@MaledongGit in that file, it had 2 trailing space instead of the single trailing line before the EOF

PS: If both trailing lines were removed, then MD047 would have gotten triggered

@SEWeiTung SEWeiTung merged commit 1e3c8a0 into nodejs:master Sep 5, 2019
@nschonni nschonni deleted the fix--MD012/no-multiple-blanks branch September 5, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants