-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update notable changes in v21.1.0 #6045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs/node#50335 (comment) Signed-off-by: Joyee Cheung <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joyeecheung
changed the title
update notable changes in v21.1.0
fix: update notable changes in v21.1.0
Oct 24, 2023
RafaelGSS
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to update the release notes on github as well.
What's blocking the tests to complete? |
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 25, 2023
CI needs to be triggered by a label. I think that is mentioned on the releasers documentation. |
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 26, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Nov 11, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 11, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 13, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 15, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 19, 2023
PR-URL: #50388 Refs: nodejs/nodejs.org#6045 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#50335 (comment)
Description
Validation
Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.