Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of package json reader #91

Closed
anonrig opened this issue Jun 1, 2023 · 1 comment
Closed

Improve the performance of package json reader #91

anonrig opened this issue Jun 1, 2023 · 1 comment
Labels
performance-agenda

Comments

@anonrig
Copy link
Member

anonrig commented Jun 1, 2023

It's possible to improve the performance of loaders by:

  • Reducing the data returned from c++/js
  • Parse JSON on C++ side, instead of JSON.parse in JS
  • Remove unnecessary caches on CJS

I've started and done most of the work, but soon I'll leave for the paternity leave and can not complete it.

Ref: nodejs/node#47991
@mhdawson mhdawson mentioned this issue Jul 5, 2023
Closed
@mhdawson mhdawson mentioned this issue Jul 19, 2023
Closed
@mhdawson mhdawson mentioned this issue Aug 2, 2023
Closed
@mhdawson mhdawson mentioned this issue Aug 16, 2023
Closed
@mhdawson mhdawson mentioned this issue Aug 30, 2023
Closed
@anonrig
Copy link
Member Author

anonrig commented Sep 6, 2023

The performance impact of this task is really low. I'll close the issue for now.

@anonrig anonrig closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance-agenda
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonrig