-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing type updates in undici.request
#2748
Labels
enhancement
New feature or request
Comments
I think Iterable covers Record, Map and Headers |
Just provide a PR and add tsd typings tests. ;) |
Sure. It's in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent PR #2708 introduced support for passing
Headers
instances,Map
instances, and iterable objects as theheaders
argument toundici.request
.However, there have been no updates to documentation or types to reflect these changes.
This oversight needs to be addressed.
I'm considering fixing this issue, but I'd appreciate input from more experienced contributors like @mcollina, @metcoder95, @KhafraDev, and @mertcanaltin. Do any of you have suggestions or thoughts on how to approach this?
One approach I'm considering is extending the existing UndiciHeaders type with a definition similar to the following:
However, this may seem a bit verbose. I'm open to alternative suggestions or approaches.
It would also be helpful if someone could provide a checklist or guidelines for updating documentation and types in situations like this.
This could ensure that similar oversights are avoided in the future.
The text was updated successfully, but these errors were encountered: