Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: issue #2026 #2032

Closed
wants to merge 1 commit into from
Closed

Conversation

AriPerkkio
Copy link

image

Example of failure on CI: https:/AriPerkkio/undici/actions/runs/4551514748/jobs/8025677893#step:14:12832

Somehow tap is able to kill the process even though workers cannot terminate. I'm not sure how it does that as the reproduction case of #2026 cannot exit main thread even when it calls process.exit().

Replace fetch with request and test case will pass.

const requests = Array(count)
-  .fill(urls.map((url) => fetch(url).then((r) => r.json())))
+  .fill(urls.map((url) => request(url).then((r) => r.body.json())))

})
} else {
const urls = [
new URL('/v4/starlink', 'https://api.spacexdata.com'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid doing any calls to external servers

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been trying to reproduce this issue with local node:http server without success. I'm serving the raw data with Content-Encoding: br header but something is still missing as the issue does not appear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think figuring that out will get us the fix.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.30 🎉

Comparison is base (a9ef509) 89.50% compared to head (8463224) 89.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   89.50%   89.81%   +0.30%     
==========================================
  Files          70       71       +1     
  Lines        6173     6174       +1     
==========================================
+ Hits         5525     5545      +20     
+ Misses        648      629      -19     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronag ronag closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants