Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eleventy 3.0.0 (>=alpha.15) causes tests to fail #14

Closed
noelforte opened this issue Jul 15, 2024 · 6 comments
Closed

Eleventy 3.0.0 (>=alpha.15) causes tests to fail #14

noelforte opened this issue Jul 15, 2024 · 6 comments
Labels
bug Something isn't working released Available to the masses! upstream Related to upstream dependencies

Comments

@noelforte
Copy link
Owner

Related to #13, can't merge until tests are able to pass. Source of regression has yet to be found, but for now this plugin only works with <= 3.0.0-alpha.14.

@noelforte noelforte pinned this issue Jul 15, 2024
@noelforte noelforte added bug Something isn't working upstream Related to upstream dependencies labels Jul 15, 2024
@paulrobertlloyd
Copy link

Experimenting with moving from Liquid to Vento via this plugin (with Eleventy 3.0.0-beta.1), and it seems that filters (added via eleventyConfig.addFilter(), but also tried using eleventyConfig.addJavaScriptFunction()) are not found.

Furthermore, following the example given for using JavaScript helper functions, I get the following error:

<p>This is something {{ italicize('really') }} important.</p>

> it.italicize is not a function

Does this relate to some of the issues being thrown up by these unit tests?

@noelforte
Copy link
Owner Author

noelforte commented Aug 16, 2024

@paulrobertlloyd Most likely, yes. I was working on an implementation to finalize the integration for filters and custom tags but life has kept me busy with other things the past month. My hope is to get back to this project in the next several weeks to address this issue which will address the breaking changes that shipped with alpha.15 as well as fix #9.

Thanks for your patience!

noelforte added a commit that referenced this issue Aug 17, 2024
breaking changes in 11ty will be handled seperately, see #13/#14
noelforte added a commit that referenced this issue Aug 17, 2024
* chore(deps): update development dependencies

* chore(deps): remove 11ty upgrade from pull

breaking changes in 11ty will be handled seperately, see #13/#14

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Noel Forte <[email protected]>
@noelforte
Copy link
Owner Author

@paulrobertlloyd Following up on my comment from yesterday, and because I didn't state it verbatim, the workaround would be to hold eleventy at version >=3.0.0-alpha.14 until I can get a release out that takes advantage of some 3.0.0 features and transitions away from what was removed (which is what's causing this plugin to break).

@paulrobertlloyd
Copy link

Thanks for the tip. FWIW, I had another bug in my site build that prevents me from using versions earlier than 3.0.0-alpha-15. But no rush; I like that Vento may allow me to write more concise templates, but will investigate further once a compatible update to this plugin has landed. Thanks again!

@noelforte
Copy link
Owner Author

noelforte commented Sep 19, 2024

@paulrobertlloyd Thanks for your patience on this, will ship in [email protected] which will also bring full-featured support of paired shortcodes and shortcodes implemented as Vento tags. Exciting stuff!

@noelforte noelforte unpinned this issue Sep 20, 2024
@paulrobertlloyd
Copy link

Awesome, I look forward to giving it a go!

@noelforte noelforte added the released Available to the masses! label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available to the masses! upstream Related to upstream dependencies
Projects
None yet
Development

No branches or pull requests

2 participants