Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating include does not update output using Eleventy dev server #38

Open
carpelli opened this issue Oct 15, 2024 · 4 comments · May be fixed by #41
Open

Updating include does not update output using Eleventy dev server #38

carpelli opened this issue Oct 15, 2024 · 4 comments · May be fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@carpelli
Copy link

carpelli commented Oct 15, 2024

Steps to reproduce

Run npx @11ty/eleventy --serve
Modify a Vento template file include.vto included by {{ include 'include.vto' }}

Expected behavior

The template is rerendered with the updated included template

Actual behavior

Site is rebuilt but the output doesn't change

Plugin version

3.0.2

Eleventy version

3.0.0

Reduced Test Case URL

No response

Additional information

Basically #34, but this time for the includes

@carpelli carpelli added the bug Something isn't working label Oct 15, 2024
@carpelli carpelli changed the title [Bug]: <title> Updating include does not update output using Eleventy dev server </title> [Bug]: Updating include does not update output using Eleventy dev server Oct 15, 2024
@noelforte
Copy link
Owner

I'll take a look later today. Just for context, are you using --serve --incremental or just --serve?

@carpelli
Copy link
Author

carpelli commented Oct 15, 2024 via email

@noelforte noelforte changed the title [Bug]: Updating include does not update output using Eleventy dev server Updating include does not update output using Eleventy dev server Oct 15, 2024
@noelforte
Copy link
Owner

noelforte commented Oct 16, 2024

No, you're good, I was able to get this reproduced, just need to dig a bit more on how to patch this in a way that preserves caching functionality for speed while also clearing things where appropriate. Then I also should write more unit tests that cover this, because right now caching and --serve don't have any test coverage.

On a somewhat related note, issues like this will be much easier to triage once I get #21 finished.

@noelforte noelforte linked a pull request Oct 20, 2024 that will close this issue
3 tasks
@noelforte
Copy link
Owner

Possible opportunity to handle this upstream so we can do it right since Vento doesn't provide any information about associations of includes to their dependents. The easy way to handle cache during development would be to "clear-all-on-save" but that's not super conservative.

I'm going to raise this upstream to see what potential options there are for "smart caching" but in the meantime I can implement a hotfix that clears the cache on every save as a holdover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants