Make method 'findBest' private

nok · Oct 31, 2017 · e2740fd · e2740fd
1 parent defe0f6
commit e2740fd
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/examples/estimator/classifier/DecisionTreeClassifier/js/basics.ipynb b/examples/estimator/classifier/DecisionTreeClassifier/js/basics.ipynb
@@ -104,7 +104,7 @@
  " this.indices = indices;\n",
  " this.classes = classes;\n",
  "\n",
- " this.findMax = function(nums) {\n",
+ " var findMax = function(nums) {\n",
  " var index = 0;\n",
  " for (var i = 0; i < nums.length; i++) {\n",
  " index = nums[i] > nums[index] ? i : index;\n",
@@ -121,7 +121,7 @@
  " return this.predict(features, this.rChilds[node]);\n",
  " }\n",
  " }\n",
- " return this.findMax(this.classes[node]);\n",
+ " return findMax(this.classes[node]);\n",
  " };\n",
  "\n",
  "};\n",

diff --git a/examples/estimator/classifier/DecisionTreeClassifier/js/basics.py b/examples/estimator/classifier/DecisionTreeClassifier/js/basics.py
@@ -25,7 +25,7 @@
  this.indices = indices;
  this.classes = classes;
 
- this.findMax = function(nums) {
+ var findMax = function(nums) {
  var index = 0;
  for (var i = 0; i < nums.length; i++) {
  index = nums[i] > nums[index] ? i : index;
@@ -42,7 +42,7 @@
  return this.predict(features, this.rChilds[node]);
  }
  }
- return this.findMax(this.classes[node]);
+ return findMax(this.classes[node]);
  };
 
 };

diff --git a/examples/estimator/classifier/DecisionTreeClassifier/js/basics_embedded.ipynb b/examples/estimator/classifier/DecisionTreeClassifier/js/basics_embedded.ipynb
@@ -98,7 +98,7 @@
  "text": [
  "var DecisionTreeClassifier = function() {\n",
  "\n",
- " this.findMax = function(nums) {\n",
+ " var findMax = function(nums) {\n",
  " var index = 0;\n",
  " for (var i = 0; i < nums.length; i++) {\n",
  " index = nums[i] > nums[index] ? i : index;\n",
@@ -161,7 +161,7 @@
  " }\n",
  " }\n",
  " \n",
- " return this.findMax(classes);\n",
+ " return findMax(classes);\n",
  " };\n",
  "\n",
  "};\n",

diff --git a/examples/estimator/classifier/DecisionTreeClassifier/js/basics_embedded.py b/examples/estimator/classifier/DecisionTreeClassifier/js/basics_embedded.py
@@ -19,7 +19,7 @@
 """
 var DecisionTreeClassifier = function() {
 
- this.findMax = function(nums) {
+ var findMax = function(nums) {
  var index = 0;
  for (var i = 0; i < nums.length; i++) {
  index = nums[i] > nums[index] ? i : index;
@@ -82,7 +82,7 @@
  }
  }
  
- return this.findMax(classes);
+ return findMax(classes);
  };
 
 };

diff --git a/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/class.embedded.txt b/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/class.embedded.txt
@@ -1,6 +1,6 @@
 var {class_name} = function() {{
 
- this.findMax = function(nums) {{
+ var findMax = function(nums) {{
  var index = 0;
  for (var i = 0; i < nums.length; i++) {{
  index = nums[i] > nums[index] ? i : index;

diff --git a/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/class.txt b/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/class.txt
@@ -6,7 +6,7 @@ var {class_name} = function(lChilds, rChilds, thresholds, indices, classes) {{
  this.indices = indices;
  this.classes = classes;
 
- this.findMax = function(nums) {{
+ var findMax = function(nums) {{
  var index = 0;
  for (var i = 0; i < nums.length; i++) {{
  index = nums[i] > nums[index] ? i : index;
@@ -23,7 +23,7 @@ var {class_name} = function(lChilds, rChilds, thresholds, indices, classes) {{
  return this.{method_name}(features, this.rChilds[node]);
  }}
  }}
- return this.findMax(this.classes[node]);
+ return findMax(this.classes[node]);
  }};
 
 }};

diff --git a/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/method.embedded.txt b/sklearn_porter/estimator/classifier/DecisionTreeClassifier/templates/js/method.embedded.txt
@@ -2,5 +2,5 @@ this.{method_name} = function(features) {{
  var classes = new Array({n_classes});
  {branches}
 
- return this.findMax(classes);
+ return findMax(classes);
 }};