fix: Remove fetch test race by awaiting the expectations in order

This prevents the fetch and fetch from cache test steps to execute concurrently.
nomasystems · Aug 29, 2023 · 2345e48 · 2345e48
1 parent 47eb613
commit 2345e48
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Tests/NMAImageFetchTests/NMAImageFetchTests.swift b/Tests/NMAImageFetchTests/NMAImageFetchTests.swift
@@ -25,6 +25,7 @@ final class NMAImageFetchTests: XCTestCase {
  XCTFail()
  }
  }
+ wait(for: [expectationWithoutCaching], timeout: 5)
  let expectationWithCaching = expectation(description: "Image request finished width caching")
  _ = imageFetch.requestImage(imageFetchRequest) { result in
  expectationWithCaching.fulfill()
@@ -35,7 +36,7 @@ final class NMAImageFetchTests: XCTestCase {
  XCTFail()
  }
  }
- waitForExpectations(timeout: 5)
+ wait(for: [expectationWithCaching], timeout: 5)
  }
 
  func testVectorLoading() throws {
@@ -54,6 +55,7 @@ final class NMAImageFetchTests: XCTestCase {
  XCTFail()
  }
  }
+ wait(for: [expectationWithoutCaching], timeout: 5)
  let expectationWithCaching = expectation(description: "Image request finished with caching")
  _ = imageFetch.requestImage(imageFetchRequest) { result in
  expectationWithCaching.fulfill()
@@ -64,7 +66,7 @@ final class NMAImageFetchTests: XCTestCase {
  XCTFail()
  }
  }
- waitForExpectations(timeout: 5)
+ wait(for: [expectationWithCaching], timeout: 5)
  }
 
  func testCancel() {