Fix external tilesets not being stored correctly #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnocentusLime
changed the title
|
Wasn't 6a27440 already merged? Maybe it ended up included in this PR accidently? |
InnocentusLime
force-pushed
the
raw-tiled-patch
branch
from
0c28732
to
77a3eca
Compare
InnocentusLime
force-pushed
the
raw-tiled-patch
branch
from
77a3eca
to
df8bbf1
Compare
Yeah, it was. I think I forgot to rebase. Should be good now |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
When a tileset is "external" (e.g. passed via
external_tilesetstomacroquad_tiled::load_map) -- it doesn't get properly incuded in theraw_tiled_mapfield of theMapstruct (as completely empty tilesets).This PR fixes it by simply injecting
map_tilesetsin the returned value. As it is pretty much the list of all the tilesets parsed and resolved.Notes
Unless someone relied on external tilesets being stored as empty tilesets (which this PR assumes is highly unlikely), this change is backwards compatible.