Introduce static field for the PropertyFormat to improve readability, add a test case #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebastianStehle so do you have any other things that I can work on now? Sadly I'm not sure how it will be with time in my case because now my school year starts, but in my free time, I'll slowly but progressively work on it :) |
|
Let me think about it. |
|
Sure :) |
|
There are requests for more integrations. Then it would be great to get some statistics for A/B tests, which actually exist today. Or docs are always welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion you gave me in #248
I also improved the naming of the PropertyFormat tests and added another HttpUrl test case.
Have a nice day :)