Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prefix for version output #3456

Closed
wants to merge 1 commit into from

Conversation

cyntler
Copy link

@cyntler cyntler commented Jun 23, 2021

Today, after installing Brew on the new MacOS and then Node, I checked the version of both binaries.
I saw that node -v displays the version as vX.X.X but npm as X.X.X.

I decided to standardize it.
A simple change.

@cyntler cyntler requested a review from a team as a code owner June 23, 2021 08:02
@wraithgar
Copy link
Member

A deceptively simple change. This is likely a discussion that would have to be made through our rfc process. We would need to see if this is even possible (it likely is not because this is the programmatic output for that flag i.e. no --json output), and if so if a bare v is the right thing to prepend. There are the tag-version-prefix and save-prefix flags to consider.

@wraithgar wraithgar added the Needs Discussion is pending a discussion label Jun 23, 2021
@darcyclarke darcyclarke added the Agenda will be discussed at the Open RFC call label Jun 23, 2021
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature labels Jun 23, 2021
@ljharb
Copy link
Contributor

ljharb commented Jun 23, 2021

This is a great idea but will definitely break many of the tools that have had to work around npm's lack of a v for a decade.

@darcyclarke darcyclarke removed the Agenda will be discussed at the Open RFC call label Jun 23, 2021
@wraithgar
Copy link
Member

This was discussed at today's open rfc meeting and it was determined that this would definitely be a breaking change. If you want to propose a way to implement this in a backwards-compatible way, feel free to open an rfc issue.

@wraithgar wraithgar closed this Jun 23, 2021
@cyntler cyntler deleted the update-version-prefix branch July 3, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion is pending a discussion Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants