Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view): filter out invalid semver #7197

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

wraithgar
Copy link
Member

node-semver has tightened its validation on what is an acceptible
version since some old packages were published to the registry. They
can no longer exceed the maximum safe integer value. Packages with
invalid semver that were published before this validation cause npm to
crash when viewing info on the package as a whole. This filters out
those invalid semver versions.

@wraithgar wraithgar requested a review from a team as a code owner February 2, 2024 21:17
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this problem (old versions with invalid semver) caused NullVoxPopuli/package-majors#15 - if you want another data point for tests

@wraithgar wraithgar merged commit d04111d into latest Feb 3, 2024
20 checks passed
@wraithgar wraithgar deleted the gar/view-bad-semver branch February 3, 2024 03:47
@github-actions github-actions bot mentioned this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants