This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
feat: upgrade to node 12 #451
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrialexandrou
approved these changes
Jan 28, 2021
| @@ -48,7 +48,11 @@ if (typeof process.browser === 'undefined') { | |||
|
|
|||
| // cleanup generated rules in the highlighter registry if they are idle for 2000ms | |||
| // they take a tremendous amount of memory if you process many languages in a server type environment. | |||
| cleanup(highlighter.registry.grammars) | |||
|
|
|||
| // this doesn't work with new highlights version, | |||
There was a problem hiding this comment.
Is 3.1.4 actually newer than 3.2.0-candidate.1? I think it's not.
Is there any problem keeping the candidate one and keep cleanup code then?
There was a problem hiding this comment.
Actually 3.1.4 is newer:
The reason for changing to newer version of highlights is to update oniguruma dependency, which is the actual blocker for supporting Node 12.
| @@ -4,7 +4,7 @@ notifications: | |||
| email: false | |||
|
|
|||
| node_js: | |||
| - 8 | |||
| - 12 | |||
There was a problem hiding this comment.
I'd also add .nvmrc since we're touching this repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlightsto use newer oniguruma dependency, which otherwise won't compile on Node 12.highlights. While trying to solve some memory consumption issues, the code is actually an antipattern, which mutates the state ofhighlighterobject. I kept the code for now to discuss how we want to proceed with the change.Closes #442
Related to github/npm#1814