fix: engine strict config issue on npm install #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Oct 14, 2024
| @@ -131,6 +131,7 @@ class RegistryFetcher extends Fetcher { | |||
| ...this.opts, | |||
| defaultTag: this.defaultTag, | |||
| before: this.before, | |||
| engineStrict: this.opts.engineStrict, | |||
There was a problem hiding this comment.
Doesn't ...this.opts from line 131 already do this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix addresses an issue where the engine-strict flag is not enforced during the version resolution phase in npm. When engine-strict is enabled, npm should only install package versions that are compatible with the current Node.js version, as specified in the package's engines field. However, prior to this fix, npm did not consider the engines.node field during version resolution, potentially leading to the installation of incompatible package versions.
By passing engineStrict, we ensure npm-pick-manifest filters out package versions that are incompatible with the current Node.js version when engineStrict is enabled.
References