Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: identity_key: CONFIG_IDENTITY_KEY no longer requires ASSERT #18023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonaias
Copy link

@jonaias jonaias commented Oct 19, 2024

The ASSERT statements were removed on commit (ae41289), but the KConfig was never updated.

In our current build, ASSERT increases ROM size by about 10%. It would be nice if, in the next SDK version, we didn't need to patch the library to fix it.

Before patch

Memory region         Used Size  Region Size  %age Used
           FLASH:      507028 B     962048 B     52.70%
             RAM:      311132 B       440 KB     69.05%
        IDT_LIST:          0 GB        32 KB      0.00%

After patch

Memory region         Used Size  Region Size  %age Used
           FLASH:      457156 B     962048 B     47.52%
             RAM:      310864 B       440 KB     69.00%
        IDT_LIST:          0 GB        32 KB      0.00%

Work sponsored by Limitless.ai

@jonaias jonaias requested a review from a team as a code owner October 19, 2024 02:31
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 19, 2024
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Oct 19, 2024
The ASSERT statements were removed on commit (ae41289), but the KConfig was never updated
@jonaias jonaias changed the title CONFIG_IDENTITY_KEY no longer requires ASSERT lib: identity_key: CONFIG_IDENTITY_KEY no longer requires ASSERT Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants