Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KKRKNWK-7116: zigbee: Move to the interrupt driven UART API #2835

Merged
merged 3 commits into from
Sep 15, 2020
Merged

KKRKNWK-7116: zigbee: Move to the interrupt driven UART API #2835

merged 3 commits into from
Sep 15, 2020

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Sep 4, 2020

  • Switch from asynchronous to interrupt driven UART API to be able to use USB CDC ACM class as the transport layer.
  • Add an implementation of ZBOSS system reset API.

@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch from 7f2ec1e to 1a3b605 Compare September 4, 2020 11:17
@tomchy tomchy marked this pull request as ready for review September 4, 2020 11:34
@tomchy tomchy requested a review from anangl September 4, 2020 11:34
@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch 4 times, most recently from e7646d0 to 5db74ae Compare September 7, 2020 16:05
maciekfabia
maciekfabia approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@maciekfabia maciekfabia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few comments to async implementation

subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch from 5db74ae to 203ed84 Compare September 10, 2020 07:13
@tomchy tomchy requested a review from rlubos September 10, 2020 11:56
@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch from 203ed84 to cbaa1d4 Compare September 11, 2020 12:19
rlubos
rlubos reviewed Sep 11, 2020
View reviewed changes
subsys/zigbee/osif/zb_nrf_platform.c Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Outdated Show resolved Hide resolved
subsys/zigbee/osif/zb_nrf_serial.c Show resolved Hide resolved
@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch 4 times, most recently from 557a9a7 to 8aad537 Compare September 14, 2020 14:11
@tomchy
zigbee: Add an implementation of system reset
3613e05 
There are cases, in which ZBOSS stack needs to reset the MCU.
The zb_reset() function is called for that purpose.
It does not imply a fault condition.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy
zigbee: Optimize zigbee serial interface
b0417bd 
Add ring buffer implementation to keep te UART in continuous RX.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy
zigbee: Move to the interrupt driven UART API
35296ed 
Switch from asynchronous to interrupt driven UART API
to be able to use USB CDC ACM class as the transport layer.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the KRKNWK-7116_add_different_uart_api_support branch from 8aad537 to 35296ed Compare September 15, 2020 07:44
@rlubos rlubos merged commit 10236d5 into nrfconnect:master Sep 15, 2020
@tomchy tomchy mentioned this pull request Mar 12, 2021
Closed
@tomchy tomchy deleted the KRKNWK-7116_add_different_uart_api_support branch May 24, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

@maciekfabia maciekfabia maciekfabia approved these changes

@mariuszpos mariuszpos Awaiting requested review from mariuszpos

@rakons rakons Awaiting requested review from rakons

@anangl anangl Awaiting requested review from anangl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomchy @rlubos @maciekfabia