Skip to content

Commit

Permalink
fix(misc): restore using legacy-peer-deps for npm installs (#16767)
Browse files Browse the repository at this point in the history
  • Loading branch information
FrozenPandaz authored May 4, 2023
1 parent 22dd46a commit 137b743
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions e2e/utils/command-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ export function getPackageManagerCommand({
runUninstalledPackage: `npx --yes`,
install: 'npm install',
ciInstall: 'npm ci',
addProd: `npm install`,
addDev: `npm install -D`,
addProd: `npm install --legacy-peer-deps`,
addDev: `npm install --legacy-peer-deps -D`,
list: 'npm ls --depth 10',
runLerna: `npx lerna`,
},
Expand Down
3 changes: 3 additions & 0 deletions packages/nx/src/utils/package-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ export function getPackageManagerCommand(
};
},
npm: () => {
// TODO: Remove this
process.env.npm_config_legacy_peer_deps ??= 'true';

return {
install: 'npm install',
ciInstall: 'npm ci',
Expand Down

1 comment on commit 137b743

@vercel
Copy link

@vercel vercel bot commented on 137b743 May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx-five.vercel.app
nx.dev

Please sign in to comment.