Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockfile generation still is buggy with 15.8.1 #15366

Closed
vicb opened this issue Mar 1, 2023 · 4 comments · Fixed by #15502
Closed

lockfile generation still is buggy with 15.8.1 #15366

vicb opened this issue Mar 1, 2023 · 4 comments · Fixed by #15502
Assignees
Labels

Comments

@vicb
Copy link
Contributor

vicb commented Mar 1, 2023

Current Behavior

When deploying to app engine

╔════════════════════════════════════════════════════════════╗
╠═ Uploading 3921 files to Google Cloud Storage             ═╣
╚════════════════════════════════════════════════════════════╝
File upload done.
Updating service [default]...
....................................................................................................................................................................................failed.
ERROR: (gcloud.app.deploy) Error Response: [9] Cloud build 5331e4df-a3a8-4e40-8954-5e82f6979efe status: FAILURE
npm ERR! code EUSAGE
npm ERR! 
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Missing: [email protected] from lock file

Expected Behavior

No error

GitHub Repo

https:/vicb/flyxc

Steps to Reproduce

  1. nx deploy - see package.json for details: nx build fxc-server --prod --skip-nx-cache && rm dist/apps/fxc-server/package-lock.json && gcloud app deploy dist/apps/fxc-server/app.yaml

I have to delete dist/apps/fxc-server/package-lock.json otherwise google cloud complains it's invalid

Nx Report

$ nx report
>  NX  Falling back to ts-node for local typescript execution. This may be a little slower.
  - To fix this, ensure @swc-node/register and @swc/core have been installed

 >  NX   Report complete - copy this into the issue template

   Node : 18.10.0
   OS   : linux x64
   npm  : 8.19.2
   
   nx                      : 15.8.1
   @nrwl/js                : 15.8.1
   @nrwl/jest              : 15.8.1
   @nrwl/linter            : 15.8.1
   @nrwl/workspace         : 15.8.1
   @nrwl/cli               : 15.8.1
   @nrwl/cypress           : 15.8.1
   @nrwl/devkit            : 15.8.1
   @nrwl/eslint-plugin-nx  : 15.8.1
   @nrwl/express           : 15.8.1
   @nrwl/node              : 15.8.1
   @nrwl/rollup            : 15.8.1
   @nrwl/tao               : 15.8.1
   @nrwl/vite              : 15.8.1
   @nrwl/web               : 15.8.1
   @nrwl/webpack           : 15.8.1
   typescript              : 4.9.5
   ---------------------------------------
   Community plugins:
   @nx-tools/nx-container : 4.0.3

Failure Logs

No response

Additional Information

No response

@vicb vicb added the type: bug label Mar 1, 2023
@AgentEnder AgentEnder added the scope: core core nx functionality label Mar 1, 2023
@nyze2oo9
Copy link

nyze2oo9 commented Mar 3, 2023

I'm having a similar issue with npm ci on Nx 15.8.2

npm ERR! Missing: [email protected] from lock file
npm ERR! Missing: [email protected] from lock file

NX Report

 >  NX   Report complete - copy this into the issue template

   Node : 18.12.1
   OS   : darwin arm64
   npm  : 8.19.2

   nx                      : 15.8.2
   @nrwl/js                : 15.8.2
   @nrwl/jest              : 15.8.2
   @nrwl/linter            : 15.8.2
   @nrwl/workspace         : 15.8.2
   @nrwl/angular           : 15.8.2
   @nrwl/cli               : 15.8.2
   @nrwl/cypress           : 15.8.2
   @nrwl/devkit            : 15.8.2
   @nrwl/eslint-plugin-nx  : 15.8.2
   @nrwl/nest              : 15.8.2
   @nrwl/node              : 15.8.2
   @nrwl/tao               : 15.8.2
   @nrwl/webpack           : 15.8.2
   @nrwl/nx-cloud          : 15.1.1
   typescript              : 4.9.5
   ---------------------------------------
   Community plugins:
   apollo-angular         : 4.2.1
   @nx-tools/nx-container : 4.0.3

npm ls ms (after npm i)

├─┬ @nestjs/[email protected]
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   └── [email protected]
│ └─┬ [email protected]
│   ├─┬ [email protected]
│   │ └─┬ [email protected]
│   │   └── [email protected]
│   └─┬ [email protected]
│     ├─┬ [email protected]
│     │ └── [email protected]
│     └── [email protected]
├─┬ @sentry/[email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected] deduped
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   └── [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected]
└─┬ [email protected]
  └── [email protected]

npm ls long (after npm i)

├─┬ @nestjs/[email protected]
│ └─┬ [email protected]
│   ├─┬ @apollo/[email protected]
│   │ └─┬ @apollo/[email protected]
│   │   └─┬ @apollo/[email protected]
│   │     └── [email protected] deduped
│   └─┬ [email protected]
│     └─┬ @apollo/[email protected]
│       └── [email protected] deduped
└─┬ @nestjs/[email protected]
  ├─┬ @grpc/[email protected]
  │ └─┬ @grpc/[email protected]
  │   ├── [email protected]
  │   └─┬ [email protected]
  │     └── [email protected]
  └─┬ @grpc/[email protected]
    ├── [email protected]
    └─┬ [email protected]
      └── [email protected] deduped

After npm i at lot of optional: true were added to the package-lock.json after integrity sha.

@nwidynski
Copy link

nwidynski commented Mar 3, 2023

Same issue on 15.8.3. Getting the following error on npm ci

npm ERR! 
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! Missing: [email protected] from lock file

@meeroslav
Copy link
Contributor

meeroslav commented Mar 6, 2023

Thank you all for reporting this. It's a very interesting chicken-and-the-egg problem.
I am looking into possible solutions

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants