Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): convert extension to lowercase before comparing extension #16727

Merged

Conversation

nosaku
Copy link
Contributor

@nosaku nosaku commented May 3, 2023

Current Behavior

In Windows there may be some files with uppercase extensions and the comparison with binaryExtensions set is done in a case sensitive manner

Expected Behavior

Compare the file extension with the set by converting the extension to lowercase

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 3:07pm

@github-actions
Copy link

github-actions bot commented May 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants