Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): do not error when no vite config is found #16746

Merged
merged 1 commit into from
May 4, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 3, 2023

Currently, if you don't have vite.config.ts file in the project, the warning we're trying to log ends up causing an error like this:

 >  NX   Cannot read properties of null (reading 'path')
TypeError: Cannot read properties of null (reading 'path')
    at getSettings (/Users/jack/projects/analog/node_modules/@nx/vite/src/executors/test/vitest.impl.js:101:124)
    at async vitestExecutor (/Users/jack/projects/analog/node_modules/@nx/vite/src/executors/test/vitest.impl.js:55:20)

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 9:23pm

@ndcunningham ndcunningham merged commit f8fe2a1 into nrwl:master May 4, 2023
@jaysoo jaysoo deleted the fix/vitest-no-config-warning branch May 4, 2023 12:05
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants