Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ssr distFolder path should be more correctly defined #16758

Merged
merged 1 commit into from
May 4, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented May 4, 2023

Current Behavior

When adding SSR to an Angular App, we rewrite the output path to match integrated monorepo style directory structure. We then assume this value to follow that structure in the template files.

Expected Behavior

We should only modify the output path of the build to add what we need, /browser and then pull the value stored in the project's config to use as the path in the template files.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez as a code owner May 4, 2023 10:29
@Coly010 Coly010 self-assigned this May 4, 2023
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 4, 2023 10:57am

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a non-blocking suggestion.

@Coly010 Coly010 force-pushed the angular/server-output-path-bundles branch from b56e601 to fa32722 Compare May 4, 2023 10:56
@Coly010 Coly010 merged commit 8484a8e into nrwl:master May 4, 2023
@Coly010 Coly010 deleted the angular/server-output-path-bundles branch May 4, 2023 11:26
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants