fix(nest): fix invalid nestjs versions #16771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
leosvelperez
force-pushed
the
nest/version-issue
branch
from
c7a1c4b
to
529d307
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
approved these changes
May 4, 2023
leosvelperez
force-pushed
the
nest/version-issue
branch
from
529d307
to
ceee1dd
Compare
jaysoo
approved these changes
May 4, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In the Angular 16 PR I updated the NestJS version to
^9.1.0so the@nestjs/schematicsinstalled version supported TS 5. This doesn't work correctly because there's no9.1.0version for@nestjs/common(somehow it was skipped).Expected Behavior
The version for
@nestjs/schematicsis handled separately from the rest of@nestjs/*packages (they are not in sync). The version for the rest of the packages was bumped to an existing version (^9.1.1).Related Issue(s)
Fixes #16752