Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StackItem to a separate package #912

Closed
fyrchik opened this issue Apr 28, 2020 · 0 comments · Fixed by #1013
Closed

Move StackItem to a separate package #912

fyrchik opened this issue Apr 28, 2020 · 0 comments · Fixed by #1013
Assignees
@AnnaShaleva
Labels
vm VM tasks/bugs/issues
Milestone
v0.90.0

Comments

@fyrchik
Copy link
Contributor

fyrchik commented Apr 28, 2020

In #911 emit.Bool was changed to convert emitted Integer to a Boolean. There is a hard-coded type 0x20. We need to move StackItemType type to a separate package. StackItem could also be moved but not so easily.
@roman-khimov roman-khimov added this to the v0.90.0 milestone Apr 28, 2020
@roman-khimov roman-khimov mentioned this issue Jun 3, 2020
Closed
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: move StackItem to a separate package
5e2fe4d 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
4f81cae 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: move StackItem to a separate package
1400654 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
d6e14dd 
There's no import cycle problem anymore, so we can do this. Part of #912
@AnnaShaleva AnnaShaleva mentioned this issue Jun 3, 2020
Merged
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: move StackItem to a separate package
bc907d7 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
5080180 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: move StackItem to a separate package
f309287 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 3, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
bfd4463 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 4, 2020
@AnnaShaleva
vm: move StackItem to a separate package
d3326ff 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 4, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
9b57f5c 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 4, 2020
@AnnaShaleva
vm: move StackItem to a separate package
2ffa927 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 4, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
f1df818 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 5, 2020
@AnnaShaleva
vm: move StackItem to a separate package
7e69a5f 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 5, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
e308d7e 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 8, 2020
@AnnaShaleva
vm: move StackItem to a separate package
4161197 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 8, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
890fc35 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 8, 2020
@AnnaShaleva
vm: move StackItem to a separate package
783f5ec 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 8, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
d0ccf45 
There's no import cycle problem anymore, so we can do this. Part of #912
AnnaShaleva added a commit that referenced this issue Jun 9, 2020
@AnnaShaleva
vm: move StackItem to a separate package
b0c7eb2 
closes #912
AnnaShaleva added a commit that referenced this issue Jun 9, 2020
@AnnaShaleva
vm: replace hardcoded Bool type constant with BooleanT type
ef1d97f 
There's no import cycle problem anymore, so we can do this. Part of #912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaShaleva AnnaShaleva

Labels
vm VM tasks/bugs/issues
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging a pull request may close this issue.

vm: move StackItem to a separate package nspcc-dev/neo-go
3 participants
@fyrchik @roman-khimov @AnnaShaleva