Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartcontract: reserve 4 bytes in NEF file #1626

Closed
wants to merge 1 commit into from

Conversation

AnnaShaleva
Copy link
Member

Changes ported from neo-project/neo#2160.

Waiting for the reference implementation to be merged.

@AnnaShaleva AnnaShaleva added the smartcontract Smart contracts and associated package label Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #1626 (0c7503e) into master (f2365e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files         241      241              
  Lines       19100    19105       +5     
==========================================
+ Hits        15770    15777       +7     
+ Misses       2341     2339       -2     
  Partials      989      989              
Impacted Files Coverage Δ
pkg/smartcontract/nef/nef.go 86.95% <100.00%> (+1.01%) ⬆️
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2365e2...0c7503e. Read the comment docs.

@roman-khimov
Copy link
Member

Obsoleted by neo-project/neo#2185.

@roman-khimov roman-khimov deleted the reserve-nef-bytes branch December 30, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smartcontract Smart contracts and associated package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants