Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NEF serialization #1672

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Fix NEF serialization #1672

merged 4 commits into from
Jan 19, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Jan 19, 2021

  1. Introduce MethodToken.
  2. Add reserved bytes.
  3. Merge compiler and version fields.

Related #1644 .

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #1672 (719dcef) into master (376c22a) will increase coverage by 0.00%.
The diff coverage is 94.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1672   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files         237      238    +1     
  Lines       19469    19486   +17     
=======================================
+ Hits        16074    16089   +15     
- Misses       2391     2393    +2     
  Partials     1004     1004           
Impacted Files Coverage Δ
pkg/smartcontract/nef/nef.go 86.56% <88.88%> (+0.62%) ⬆️
pkg/core/interop/context.go 94.44% <100.00%> (-0.11%) ⬇️
pkg/io/binaryReader.go 100.00% <100.00%> (ø)
pkg/smartcontract/nef/method_token.go 100.00% <100.00%> (ø)
pkg/consensus/consensus.go 68.13% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376c22a...719dcef. Read the comment docs.

@fyrchik fyrchik mentioned this pull request Jan 19, 2021
@roman-khimov roman-khimov merged commit fbbcb16 into master Jan 19, 2021
@roman-khimov roman-khimov deleted the fix/nef branch January 19, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants