Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP17/NEP11 onPayments #1712

Merged
merged 2 commits into from
Feb 5, 2021
Merged

NEP17/NEP11 onPayments #1712

merged 2 commits into from
Feb 5, 2021

Conversation

roman-khimov
Copy link
Member

Problem

neo-project/neo#2287

Solution

TBD: tests for nep11.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1712 (44a848f) into master (b1977ea) will decrease coverage by 0.02%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   82.49%   82.47%   -0.03%     
==========================================
  Files         255      255              
  Lines       21197    21211      +14     
==========================================
+ Hits        17487    17494       +7     
- Misses       2624     2631       +7     
  Partials     1086     1086              
Impacted Files Coverage Δ
pkg/smartcontract/manifest/manifest.go 68.57% <ø> (ø)
pkg/core/native/nonfungible.go 78.60% <35.71%> (-3.22%) ⬇️
pkg/core/native/native_nep17.go 78.26% <100.00%> (ø)
pkg/core/native/notary.go 87.11% <100.00%> (ø)
pkg/rpc/client/wsclient.go 82.70% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1977ea...cd9b344. Read the comment docs.

@roman-khimov roman-khimov merged commit aad2b3a into master Feb 5, 2021
@roman-khimov roman-khimov deleted the nep17-nep11-onpayments branch February 5, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants