Fix operations with storage groups #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `storagegroup.CollectMembers` function could return error with text `data must be 64-bytes long`. According to the message it is not clear which data is incorrect. Now context has been added to the error so that it is clear at what stage it occurs. Refs #2488. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `storagegroup.CollectMembers` function could return error with text `data must be 64-bytes long` if any of the split members were without homomorphic checksum or with the invalid one. Including the bypass of the splitting chain, and the error occurred already after at stage `tz.Concat`. The correct format of the homomorphic checksum is required to form the group, so it is required to do an in-place check. Check each element of `IterateSplitLeaves` iterator and break traversal on any checksum problem. Refs #2488. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `storagegroup.CollectMembers` function ignored absence of the object ID in the member's child header. This could lead to incorrect storage group formation, and also hid problem objects in the system (ID is a required field for any object). Immediately return error from `CollectMembers` if any child of any member is without ID. Refs #2488. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
+ Coverage 29.26% 29.34% +0.08%
==========================================
Files 399 401 +2
Lines 30390 30396 +6
==========================================
+ Hits 8893 8921 +28
+ Misses 20761 20739 -22
Partials 736 736
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
force-pushed
the
bugfix/storagegroup-ops
branch
from
bacb627
to
9fa0e44
Compare
Previously, storage nodes didn't check homomorphic checksum correctness in incoming objects. When homomorphic hashing is required in the container, nodes accepted objects without homomorphic hash header. This could lead to subsequent problems with storage group creation because it expects checksums in the members' headers. Make storage nodes to check that homomorphic checksum of the new object payload is set and has correct format according to TillichZemor algo. If homomorphic hashing is disabled, the header is unchecked. Exact TZ hash value is unchecked for now due to performance issues. Refs #2488. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, storage nodes didn't calculate and set homomorphic payload checksum for the sliced objects even when it was required. This could affect Data Audit subsystem working with homomorphic hashes. Bypass hashing option from `slicingTarget` to the underlying `Slicer`. Fixes #2488. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/storagegroup-ops
branch
from
9fa0e44
to
98a0a7e
Compare
carpawell
reviewed
Aug 14, 2023
Utility iterates over all objects and asserts if homomorphic checksum format is compliant with the container policy. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/storagegroup-ops
branch
from
d85954c
to
70704d3
Compare
…objects" This reverts commit 70704d3. The utility may be useful in the future, for example, as part of NeoFS Lens app. Thus, it's retained in the history. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/storagegroup-ops
branch
from
38567e6
to
28cf719
Compare
carpawell
approved these changes
Aug 15, 2023
roman-khimov
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression came #2470
no changelog needed