Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Update and fix linter #2493

Merged
merged 4 commits into from
Aug 11, 2023
Merged

fix/Update and fix linter #2493

merged 4 commits into from
Aug 11, 2023

Conversation

carpawell
Copy link
Member

No description provided.

@carpawell
Update linter version
ebdb443 
Signed-off-by: Pavel Karpy <[email protected]>
@carpawell
*: Drop/ignore unused parameters
b134dbb 
Signed-off-by: Pavel Karpy <[email protected]>
@carpawell
adm: Add context to initialization errors
c3a1903 
Also fix the liner:
`revive  if-return: redundant if ...; err != nil check, just return error instead.`

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell
blobovnicza: Speed up upperPowerOfTwo
afdf9c9 
Also fix the liner:
`revive  empty-block: this block is empty, you can remove it`

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #2493 (8796e1a) into master (9f0077e) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 35.80%.

❗ Current head 8796e1a differs from pull request most recent head afdf9c9. Consider uploading reports for the commit afdf9c9 to get more accurate results

@@           Coverage Diff           @@
##           master    #2493   +/-   ##
=======================================
  Coverage   29.25%   29.25%           
=======================================
  Files         399      399           
  Lines       30368    30391   +23     
=======================================
+ Hits         8883     8892    +9     
- Misses      20749    20763   +14     
  Partials      736      736
Files Changed Coverage Δ
cmd/neofs-adm/internal/modules/config/config.go 30.98% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/balance.go 0.00% <0.00%> (ø)
...md/neofs-adm/internal/modules/morph/dump_hashes.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/epoch.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/initialize.go 0.00% <0.00%> (ø)
...d/neofs-adm/internal/modules/morph/local_client.go 0.00% <0.00%> (ø)
cmd/neofs-node/config.go 0.00% <0.00%> (ø)
cmd/neofs-node/container.go 0.00% <0.00%> (ø)
pkg/innerring/blocktimer.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/process_epoch.go 0.00% <0.00%> (ø)
... and 11 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthulhu-rider cthulhu-rider merged commit c6604ab into nspcc-dev:master Aug 11, 2023
6 of 8 checks passed
@carpawell carpawell deleted the fix/linter branch August 11, 2023 09:33
@vvarg229 vvarg229 mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

Assignees

@carpawell carpawell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carpawell @roman-khimov @cthulhu-rider