neofs-cli: add check commands positional arguments #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
=======================================
Coverage 29.69% 29.69%
=======================================
Files 404 404
Lines 30711 30711
=======================================
Hits 9119 9119
- Misses 20823 20824 +1
+ Partials 769 768 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AliceInHunterland
force-pushed
the
bugfix/1941-cli-args-check
branch
from
a81c47d
to
2712480
Compare
cthulhu-rider
approved these changes
Aug 24, 2023
Added cobra's check if positional arguments to prevent logically incorrect argument usage and passing redundant arguments to the commands. Closes #1941. Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
bugfix/1941-cli-args-check
branch
from
2712480
to
f70e000
Compare
roman-khimov
approved these changes
Aug 24, 2023
carpawell
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Cobra's check of positional arguments to prevent logically incorrect argument usage and passing redundant arguments to the commands.
Closes #1941.