fix/Removed object listing #2526
Conversation
carpawell
force-pushed
the
fix/removed-object-listing
branch
from
0ba3e7f
to
e4a979b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
=======================================
Coverage 29.68% 29.69%
=======================================
Files 404 404
Lines 30711 30718 +7
=======================================
+ Hits 9117 9122 +5
- Misses 20825 20826 +1
- Partials 769 770 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carpawell
force-pushed
the
fix/removed-object-listing
branch
3 times, most recently
from
3e9bc4b
to
0eb8342
Compare
| @@ -121,7 +121,7 @@ func (db *DB) selectObjects(tx *bbolt.Tx, cnr cid.ID, fs object.SearchFilters, c | |||
| addr.SetContainer(cnr) | |||
| addr.SetObject(id) | |||
|
|
|||
| if objectStatus(tx, addr, currEpoch) > 0 { | |||
| if objectStatus(tx, addr, currEpoch) > 0 && !objectLocked(tx, cnr, id) { | |||
There was a problem hiding this comment.
did you think about return specific status from objectStatus for locked objects?
There was a problem hiding this comment.
what is your idea exactly? in search operations be ready to return objects and status code if any locked objects have been found?
There was a problem hiding this comment.
oh, sorry, got you wrong
There was a problem hiding this comment.
found your idea usefull (but current codebase does not require a separate code for removed-but-locked objects, so 0 is ok for now), check, please
carpawell
force-pushed
the
fix/removed-object-listing
branch
2 times, most recently
from
64aff79
to
4f133ae
Compare
carpawell
force-pushed
the
fix/removed-object-listing
branch
from
4f133ae
to
e8c4c77
Compare
Signed-off-by: Pavel Karpy <[email protected]>
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <[email protected]>
It makes logic more reliable if a single function is responsible for the removed/expired/locked statuses. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/removed-object-listing
branch
from
e8c4c77
to
3ec865e
Compare
No description provided.