ir: remove contracts.alphabet.amount from config
#2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
==========================================
- Coverage 23.49% 23.47% -0.03%
==========================================
Files 776 776
Lines 46594 46552 -42
==========================================
- Hits 10949 10928 -21
+ Misses 34780 34758 -22
- Partials 865 866 +1 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
2292-remove-contracts-alphabet-amount
branch
from
65b5ff3
to
a2cdb5c
Compare
carpawell
approved these changes
Oct 4, 2024
roman-khimov
approved these changes
Oct 7, 2024
Remove option from the code and from the example configs. Update docs. Closes #2292. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2292-remove-contracts-alphabet-amount
branch
from
a2cdb5c
to
22a3ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2292.
I found the only place where this option is mentioned. Do I need to count the number of alphabet contracts from the config or take this number from
morph?