Upd/go 1.22 #618
Merged
Upd/go 1.22 #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add 1.23 for tests. Signed-off-by: Pavel Karpy <[email protected]>
They collide with internal functions now. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
Closes #493. Signed-off-by: Pavel Karpy <[email protected]>
This follows our new go version policy: nspcc-dev/.github#31. Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
`rand.Read` are exceptions since it was already nolinted with some reasoning. Signed-off-by: Pavel Karpy <[email protected]>
Closes #552. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
requested review from
roman-khimov,
cthulhu-rider and
smallhive
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 54.43% 54.38% -0.05%
==========================================
Files 164 164
Lines 19172 19152 -20
==========================================
- Hits 10436 10416 -20
Misses 8338 8338
Partials 398 398 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Aug 20, 2024
smallhive
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.