feat: add NewError function #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @nukosuke kindly review this PR ya. thank you :) |
Might want to add this commentary to doc comment to explain why the constructor of API error is exposed. |
dzakaammar
force-pushed
the
new-error-func
branch
from
de471f4
to
ac9ef6d
Compare
|
@nukosuke sure, I just update the comment. thank you |
|
thanks @nukosuke, it would be nice if you could create tag for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since every errors from each API will be wrapped by the Error type. Here i add a new function to initialize the Error type publicly. Typically, this function will be useful for unit testing and mocking purposes in the client side to test their behavior by the API response.