Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return value type of Error on NewError #258

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

dzakaammar
Copy link

Turns out that the wrapped error from each API is a value type of Error. Then we need to make the NewError returns the same type.

@nukosuke nukosuke merged commit c5a8eb7 into nukosuke:master Feb 15, 2023
@nukosuke
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants