feat(.github/workflows): Firebase CI/CD #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgahaha
force-pushed
the
feature-firebase-ci-cd
branch
5 times, most recently
from
88ba8c4
to
a04ad80
Compare
Create a CI/CD workflow for Firebase distribution.
olgahaha
force-pushed
the
feature-firebase-ci-cd
branch
from
a04ad80
to
540347e
Compare
shc261392
reviewed
Apr 2, 2024
There was a problem hiding this comment.
@olgahaha
Node 16 is deprecated and Github is planning transitioning to node 20 on Spring 2024.
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
It would probably be better to build with node 20 and --legacy-peer-deps (to solve peer dependency conflict when using node>16)
olgahaha
force-pushed
the
feature-firebase-ci-cd
branch
from
5d5ed65
to
91907ba
Compare
olgahaha
force-pushed
the
feature-firebase-ci-cd
branch
from
91907ba
to
5ca67d7
Compare
shc261392
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
The issue is also created on Asana