feat: change explore tab to collection tab #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
Signed-off-by: James Chien <[email protected]>
olgahaha
reviewed
Apr 25, 2024
src/app/features/home/home.page.ts
Outdated
| @@ -63,7 +63,7 @@ import { PrefetchingDialogComponent } from './onboarding/prefetching-dialog/pref | |||
| export class HomePage { | |||
| readonly initialTabIndex = 0; | |||
| private readonly afterCaptureTabIndex = 0; | |||
| private readonly exploreTabIndex = 2; | |||
| private readonly CollectionTabIndex = 2; | |||
There was a problem hiding this comment.
Please follow the naming rule - start with lowercase.
| } | ||
|
|
||
| navigateBackExploreIframe() { | ||
| this.exploreIframe?.nativeElement.contentWindow?.postMessage( | ||
| navigateBackcollectionIframe() { |
There was a problem hiding this comment.
navigateBackCollectionIframe
| @@ -10,14 +10,13 @@ export class IframeService { | |||
|
|
|||
| private readonly preferences = this.preferenceManager.getPreferences(this.id); | |||
|
|
|||
| readonly exploreTabRefreshRequested$ = new BehaviorSubject(new Date()); | |||
| readonly CollectionTabRefreshRequested$ = new BehaviorSubject(new Date()); | |||
There was a problem hiding this comment.
Please follow the naming rule - start with lowercase.
|
|
||
| readonly exploreTabIframeNavigateBack$ = | ||
| this._exploreTabIframeNavigateBack$.asObservable(); | ||
| readonly CollectionTabIframeNavigateBack$ = |
There was a problem hiding this comment.
Please follow the naming rule - start with lowercase.
| private readonly _exploreTabIframeNavigateBack$ = new ReplaySubject<boolean>( | ||
| 1 | ||
| ); | ||
| private readonly _CollectionTabIframeNavigateBack$ = |
There was a problem hiding this comment.
Please follow the naming rule - start with lowercase.
Signed-off-by: James Chien <[email protected]>
olgahaha
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
┆The issue is also created on Asana