Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in place of Disqus #3782

Open
SpookyYomo opened this issue Aug 20, 2024 · 4 comments
Open

Text in place of Disqus #3782

SpookyYomo opened this issue Aug 20, 2024 · 4 comments

Comments

@SpookyYomo
Copy link

SpookyYomo commented Aug 20, 2024

Is your feature request related to a problem? Please describe.

With reference to #3766 (comment), Disqus comments do not show up for various reasons, such as Privacy Protectors, particularly so on the likes of privacy-focused browsers, such as Brave (not tested), Hardened Firefox (see: ArkenFox) etc.

Describe the solution you'd like

Just as there are websites that still have a box around the expected location of an advertisement begging for you to disable your ad-block, we could have a placeholder suggested box that suggests Disqus has failed to load due to the user's browser. If the user-agent string is Firefox, as in the referenced comment, suggest to disable Enhanced Tracking Protection and reload the page. (Firefox extensions, with the likes of DecentralEyes, CanvasBlocker, and PrivacyBadger should be left to the user to decipher as to what is interfering with Disqus.)

Describe alternatives you've considered

We hope the user doesn't realise Disqus is a thing.

@ravern
Copy link
Member

ravern commented Aug 28, 2024

@SpookyYomo shall we scope this issue to only solving for Firefox right now (via user-agent string as mentioned)?

We could figure out expanding the detection of ad-blocking in general to future issues.

@joshcangit
Copy link

joshcangit commented Aug 28, 2024

If the issue is with Firefox's Enhanced Tracking Protection, then just add nusmod.com to Manage Exceptions... and save it.
That way, the whole site including the comment section would be unblocked.

@ravern
Copy link
Member

ravern commented Aug 28, 2024

If the issue is with Firefox's Enhanced Tracking Protection, then just add nusmod.com to Manage Exceptions... and save it. That way, the whole site including the comment section would be unblocked.

Yeah, that's the point of this issue, to have some kind of infobox on NUSMods to inform the user of this solution.

@SpookyYomo
Copy link
Author

@SpookyYomo shall we scope this issue to only solving for Firefox right now (via user-agent string as mentioned)?

We could figure out expanding the detection of ad-blocking in general to future issues.

Hi @ravern, I am not privy to the difficulties of frontend myself, but I assumed drawing a box in place of Disqus with an "Oopsie, we couldn't load the comments from Disqus, please check your browser!" would have been equally difficult across browsers, but for firefox you'd just have an if conditional to change the displayed text to then add "Do you have Firefox Enhanced Tracking Protection enabled?" or something similar.
My issue filed was just a suggestion to provide end user indication and not necessary propose the exact means by which this end user indicator should have been, please do what makes most sense for as a dev and for the project, freely bending the spirit of my little suggestion :)

@ravern ravern added the taken label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants