-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lifecycle hooks #54
Comments
I think it is a good idea ! |
Yes they should be injectable. Exactly like plugins currently. And Yes, I think it should be the same interface. It's frequent that plugins don't implement lifecycle methods. So I think these methods could be extracted as a separate concern. The kernel will start/stop all the |
@pith you're right. This is a must for the 1.0 milestone. I wonder If we might or not fullfill the JSR 250 which purpose is Resource Management. We have to be carefull that when we scan for Lifecycle we do not reach plugin themselves. |
I think the JSR 250 is also a must have but in another issue. |
Currently
start()
andstop()
methods comes from thePlugin
interface. It can be a good idea to move then to a newLifecycle
interface. TheAbstractPlugin
should extends this new interface for compatibility.It will allow application developers to easily start/stop resources without creating a
Plugin
.Lifecycle
implementations can be scanned during the init phase so there will be no need forServiceLoader
here.The text was updated successfully, but these errors were encountered: