Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alias): resolve module using nuxt kit #2504

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

dargmuesli
Copy link
Collaborator

@dargmuesli dargmuesli commented Oct 18, 2023

πŸ”— Linked issue

Resolves #2055

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Not using shamefully-hoist leads to issues related to the dependencies js-cookie, cookie-es and ufo:

"js-cookie" is imported by "virtual:.nuxt/i18n.internal.mjs", but could not be resolved – treating it as an external dependency. and so on.

Also, #2055 should be fully resolved with those changes, making the workaround given in the issue unnecessary.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thanks!

@kazupon kazupon merged commit 2ea8c39 into nuxt-modules:main Oct 19, 2023
7 checks passed
@dargmuesli dargmuesli deleted the fix/resolve branch October 19, 2023 12:57
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR Cannot resolve vue-i18n on pnpm! please install it on 'node_modules'
2 participants